netdev - Re: [PATCH bpf-next] selftests/bpf: fix compiler warning in BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e690d92-f385-6d79-4bb0-6dc8d9103309@fb.com>
Date:   Mon, 8 Mar 2021 21:29:43 -0800
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andrii@...nel.org>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <ast@...com>, <daniel@...earbox.net>
CC:     <kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix compiler warning in
 BPF_KPROBE definition in loop6.c



On 3/8/21 8:43 PM, Andrii Nakryiko wrote:
> Add missing return type to BPF_KPROBE definition. Without it, compiler
> generates the following warning:
> 
> progs/loop6.c:68:12: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
> BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs,
>             ^
> 1 warning generated.
> 
> Fixes: 86a35af628e5 ("selftests/bpf: Add a verifier scale test with unknown bounded loop")
> Signed-off-by: Andrii Nakryiko <andrii@...nel.org>

Oh, my bad. Thanks for fixing it!
Acked-by: Yonghong Song <yhs@...com>