[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1c06cb74-f0b0-66e5-a594-ed1ee9bc876e@canonical.com>
Date: Wed, 10 Mar 2021 16:05:20 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To: Tom Rix <trix@...hat.com>, Lee Jones <lee.jones@...aro.org>
Cc: Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Dinh Nguyen <dinguyen@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Moritz Fischer <mdf@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
linux-edac@...r.kernel.org, linux-fpga@...r.kernel.org,
netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
arm@...nel.org, soc@...nel.org, Arnd Bergmann <arnd@...db.de>,
Olof Johansson <olof@...om.net>
Subject: Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to
ARCH_SOCFPGA64
On 10/03/2021 15:45, Tom Rix wrote:
>
> On 3/10/21 1:45 AM, Lee Jones wrote:
>> On Wed, 10 Mar 2021, Krzysztof Kozlowski wrote:
>>
>>> Prepare for merging Stratix 10, Agilex and N5X into one arm64
>>> architecture by first renaming the ARCH_STRATIX10 into ARCH_SOCFPGA64.
>>>
>>> The existing ARCH_SOCFPGA (in ARMv7) Kconfig symbol cannot be used
>>> because altera_edac driver builds differently between them (with
>>> ifdefs).
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>>> ---
>>> arch/arm64/Kconfig.platforms | 7 ++++---
>>> arch/arm64/boot/dts/altera/Makefile | 2 +-
>>> arch/arm64/configs/defconfig | 2 +-
>>> drivers/clk/Makefile | 2 +-
>>> drivers/clk/socfpga/Kconfig | 4 ++--
>>> drivers/edac/Kconfig | 2 +-
>>> drivers/edac/altera_edac.c | 10 +++++-----
>>> drivers/firmware/Kconfig | 2 +-
>>> drivers/fpga/Kconfig | 2 +-
>>> drivers/mfd/Kconfig | 2 +-
>> If it's okay with everyone else, it'll be okay with me:
>>
>> Acked-by: Lee Jones <lee.jones@...aro.org>
>
> I think the name is too broad, from the description in the config
>
> + bool "Intel's SoCFPGA ARMv8 Families"
>
> A better name would be ARCH_INTEL_SOCFPGA64
>
> So other vendors like Xilinx could do their own thing.
Many other architectures do not have vendor prefix (TEGRA, EXYNOS,
ZYNQMP etc). I would call it the same as in ARMv7 - ARCH_SOCFPGA - but
the Altera EDAC driver depends on these symbols to be different.
Anyway, I don't mind using something else for the name.
Best regards,
Krzysztof
Powered by blists - more mailing lists