netdev - [RFC PATCH net] net: stmmac: Fix hardware TX timestamping on queue with tc-etf enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210310151033.630349-1-vladimir.oltean@nxp.com>
Date:   Wed, 10 Mar 2021 17:10:33 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org
Cc:     Vinicius Costa Gomes <vinicius.gomes@...el.com>
Subject: [RFC PATCH net] net: stmmac: Fix hardware TX timestamping on queue with tc-etf enabled

After commit 29d98f54a4fe ("net: enetc: allow hardware timestamping on
TX queues with tc-etf enabled"), I went through the other drivers that
offload tc-etf, and I believe I found a similar bug in stmmac.

Fixes: 579a25a854d4 ("net: stmmac: Initial support for TBS")
Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 208cae344ffa..1393898a7d6d 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3636,6 +3636,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev)
 
 		tbs_desc = &tx_q->dma_entx[first_entry];
 		stmmac_set_desc_tbs(priv, tbs_desc, ts.tv_sec, ts.tv_nsec);
+		skb->tstamp = ktime_set(0, 0);
 	}
 
 	stmmac_set_tx_owner(priv, first);
-- 
2.25.1