netdev - Re: [PATCH net-next 01/14] nexthop: Pass nh_config to replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7712489-cd96-0bca-de2d-d75dd2bf1671@gmail.com>
Date:   Thu, 11 Mar 2021 08:20:19 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     Ido Schimmel <idosch@...dia.com>, David Ahern <dsahern@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 01/14] nexthop: Pass nh_config to
 replace_nexthop()

On 3/10/21 8:02 AM, Petr Machata wrote:
> Currently, replace assumes that the new group that is given is a
> fully-formed object. But mpath groups really only have one attribute, and
> that is the constituent next hop configuration. This may not be universally
> true. From the usability perspective, it is desirable to allow the replace
> operation to adjust just the constituent next hop configuration and leave
> the group attributes as such intact.
> 
> But the object that keeps track of whether an attribute was or was not
> given is the nh_config object, not the next hop or next-hop group. To allow
> (selective) attribute updates during NH group replacement, propagate `cfg'
> to replace_nexthop() and further to replace_nexthop_grp().
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/ipv4/nexthop.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>