netdev - Re: [PATCH net-next 02/14] nexthop: __nh_notifier_single_info_init(): Make nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <381ed37c-74ac-4fc4-734b-f1304128e609@gmail.com>
Date:   Thu, 11 Mar 2021 08:21:37 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>, netdev@...r.kernel.org
Cc:     Ido Schimmel <idosch@...dia.com>, David Ahern <dsahern@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 02/14] nexthop: __nh_notifier_single_info_init():
 Make nh_info an argument

On 3/10/21 8:02 AM, Petr Machata wrote:
> The cited function currently uses rtnl_dereference() to get nh_info from a
> handed-in nexthop. However, under the resilient hashing scheme, this
> function will not always be called under RTNL, sometimes the mutual
> exclusion will be achieved differently. Therefore move the nh_info
> extraction from the function to its callers to make it possible to use a
> different synchronization guarantee.
> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/ipv4/nexthop.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>