netdev - Re: [PATCH net-next 04/14] nexthop: Add netlink defines and enumerators for resilient NH groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33a20197-78b7-847d-7657-7a33ba9fef3b@gmail.com>
Date:   Thu, 11 Mar 2021 08:49:41 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>
Cc:     netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
        David Ahern <dsahern@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 04/14] nexthop: Add netlink defines and
 enumerators for resilient NH groups

On 3/11/21 8:45 AM, Petr Machata wrote:
> 
> David Ahern <dsahern@...il.com> writes:
> 
>> On 3/10/21 8:02 AM, Petr Machata wrote:
>>> diff --git a/include/uapi/linux/nexthop.h b/include/uapi/linux/nexthop.h
>>> index 2d4a1e784cf0..8efebf3cb9c7 100644
>>> --- a/include/uapi/linux/nexthop.h
>>> +++ b/include/uapi/linux/nexthop.h
>>> @@ -22,6 +22,7 @@ struct nexthop_grp {
>>>  
>>>  enum {
>>>  	NEXTHOP_GRP_TYPE_MPATH,  /* default type if not specified */
>>
>> Update the above comment that it is for legacy, hash based multipath.
> 
> Maybe this would make sense?
> 
> 	NEXTHOP_GRP_TYPE_MPATH,  /* hash-threshold nexthop group */
> 

yes, the description is fine. keep the comment about 'default type'.