netdev - Re: [PATCH net-next 03/14] nexthop: Add a dedicated flag for multipath next-hop groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c703efe-0357-e83a-f5b0-3fbba1b3228e@gmail.com>
Date:   Thu, 11 Mar 2021 08:53:26 -0700
From:   David Ahern <dsahern@...il.com>
To:     Petr Machata <petrm@...dia.com>
Cc:     netdev@...r.kernel.org, Ido Schimmel <idosch@...dia.com>,
        David Ahern <dsahern@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 03/14] nexthop: Add a dedicated flag for
 multipath next-hop groups

On 3/11/21 8:39 AM, Petr Machata wrote:
> 
> David Ahern <dsahern@...il.com> writes:
> 
>>> diff --git a/include/net/nexthop.h b/include/net/nexthop.h
>>> index 7bc057aee40b..5062c2c08e2b 100644
>>> --- a/include/net/nexthop.h
>>> +++ b/include/net/nexthop.h
>>> @@ -80,6 +80,7 @@ struct nh_grp_entry {
>>>  struct nh_group {
>>>  	struct nh_group		*spare; /* spare group for removals */
>>>  	u16			num_nh;
>>> +	bool			is_multipath;
>>>  	bool			mpath;
>>
>>
>> It would be good to rename the existing type 'mpath' to something else.
>> You have 'resilient' as a group type later, so maybe rename this one to
>> hash or hash_threshold.
> 
> All right, I'll send a follow-up with that.
> 

I'm fine with the rename being a followup after this patch set or as the
last patch in this set.