netdev - Re: [PATCH mlx5-next 6/9] RDMA/mlx5: Use represntor E-Switch when getting netdev and metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 11 Mar 2021 13:33:35 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, Mark Bloch <mbloch@...dia.com>
Subject: Re: [PATCH mlx5-next 6/9] RDMA/mlx5: Use represntor E-Switch when
 getting netdev and metadata

On Wed, Mar 10, 2021 at 11:09:12PM -0800, Saeed Mahameed wrote:
> From: Mark Bloch <mbloch@...dia.com>
> 
> Now that a pointer to the managing E-Switch is stored in the representor
> use it.
> 
> Signed-off-by: Mark Bloch <mbloch@...dia.com>
> Reviewed-by: Saeed Mahameed <saeedm@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/infiniband/hw/mlx5/fs.c     | 2 +-
>  drivers/infiniband/hw/mlx5/ib_rep.c | 2 +-
>  drivers/infiniband/hw/mlx5/main.c   | 3 +--
>  3 files changed, 3 insertions(+), 4 deletions(-)

Spelling error in the subject

 
> diff --git a/drivers/infiniband/hw/mlx5/fs.c b/drivers/infiniband/hw/mlx5/fs.c
> index 25da0b05b4e2..01370d9a871a 100644
> --- a/drivers/infiniband/hw/mlx5/fs.c
> +++ b/drivers/infiniband/hw/mlx5/fs.c
> @@ -879,7 +879,7 @@ static void mlx5_ib_set_rule_source_port(struct mlx5_ib_dev *dev,
>  				    misc_parameters_2);
>  
>  		MLX5_SET(fte_match_set_misc2, misc, metadata_reg_c_0,
> -			 mlx5_eswitch_get_vport_metadata_for_match(esw,
> +			 mlx5_eswitch_get_vport_metadata_for_match(rep->esw,
>  								   rep->vport));

Why not change the esw reference above too?

Seems Ok otherwise

Acked-by: Jason Gunthorpe <jgg@...dia.com>

Jason