netdev - Re: [PATCH net-next 1/2] e1000e: Leverage direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210315140422.7a3d3bb2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 15 Mar 2021 14:04:22 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, Chen Yu <yu.c.chen@...el.com>,
        netdev@...r.kernel.org, sassmann@...hat.com,
        kai.heng.feng@...onical.com, rjw@...ysocki.net,
        len.brown@...el.com, todd.e.brandt@...el.com,
        sasha.neftin@...el.com, vitaly.lifshits@...el.com,
        Dvora Fuxbrumer <dvorax.fuxbrumer@...ux.intel.com>
Subject: Re: [PATCH net-next 1/2] e1000e: Leverage direct_complete to speed
 up s2ram

On Mon, 15 Mar 2021 12:02:30 -0700 Tony Nguyen wrote:
> +static __maybe_unused int e1000e_pm_prepare(struct device *dev)
> +{
> +	return pm_runtime_suspended(dev) &&
> +		pm_suspend_via_firmware();

nit: I don't think you need to mark functions called by __maybe_unused
     as __maybe_unused, do you?

The series LGTM although I don't know much about PM.