netdev - Re: [PATCH net-next 1/2] e1000e: Leverage direct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210316075346.GA125266@chenyu-desktop>
Date:   Tue, 16 Mar 2021 15:53:46 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>, davem@...emloft.net,
        netdev@...r.kernel.org, sassmann@...hat.com,
        kai.heng.feng@...onical.com, rjw@...ysocki.net,
        len.brown@...el.com, todd.e.brandt@...el.com,
        sasha.neftin@...el.com, vitaly.lifshits@...el.com,
        "yu.c.chen@...el.com Dvora Fuxbrumer" 
        <dvorax.fuxbrumer@...ux.intel.com>
Subject: Re: [PATCH net-next 1/2] e1000e: Leverage direct_complete to speed
 up s2ram

Hi Jakub,
thanks for taking a look!
On Mon, Mar 15, 2021 at 02:04:22PM -0700, Jakub Kicinski wrote:
> On Mon, 15 Mar 2021 12:02:30 -0700 Tony Nguyen wrote:
> > +static __maybe_unused int e1000e_pm_prepare(struct device *dev)
> > +{
> > +	return pm_runtime_suspended(dev) &&
> > +		pm_suspend_via_firmware();
> 
> nit: I don't think you need to mark functions called by __maybe_unused
>      as __maybe_unused, do you?
> 
Not sure which function do you refer to having the __maybe_unused attribute
and invokes this e1000e_pm_prepare()?
I copied the definition from e1000e_pm_suspend() that if CONFIG_PM_SLEEP is not
set, we might get compile error of such PM hooks in this driver.
> The series LGTM although I don't know much about PM.
Thanks!

Best,
Chenyu