netdev - Re: [PATCH -next] iwlwifi: mvm: fix old-style static const declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Mar 2021 08:02:08 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "weiyongjun1@...wei.com" <weiyongjun1@...wei.com>,
        "Greenman, Gregory" <gregory.greenman@...el.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "hulkci@...wei.com" <hulkci@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH -next] iwlwifi: mvm: fix old-style static const
 declaration

On Thu, 2021-03-04 at 10:22 +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> GCC reports warning as follows:
> 
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: warning:
>  'static' is not at beginning of declaration [-Wold-style-declaration]
>    14 | const static struct iwl_rfi_lut_entry iwl_rfi_table[IWL_RFI_LUT_SIZE] = {
>       | ^~~~~
> 
> Move static to the beginning of declaration.
> 
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---

Thanks, I applied this to our internal tree and it will reach the
mainline following our usual process.

--
Cheers,
Luca.