netdev - Re: [PATCH net-next] iwlwifi: fix old-style-declaration warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94eedcd0501ba64cfa17fc852dd4f22950a8c435.camel@intel.com>
Date:   Tue, 23 Mar 2021 08:04:35 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "Greenman, Gregory" <gregory.greenman@...el.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "arnd@...nel.org" <arnd@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>
Subject: Re: [PATCH net-next] iwlwifi: fix old-style-declaration warning

On Mon, 2021-03-22 at 22:51 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The correct order is 'static const', not 'const static', as seen from
> make W=1:
> 
> drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:14:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
> 
> Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Thanks, Arnd! But I just applied the patch Wei Yongjun submitted, so
we'll go with that one.

--
Cheers,
Luca.