netdev - Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce5b1c2f-1b88-d4c8-2afd-867db9092606@gmail.com>
Date:   Wed, 24 Mar 2021 20:47:53 +0100
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Andreas Roeseler <andreas.a.roeseler@...il.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        kuba@...nel.org
Subject: Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE
 messages



On 3/24/21 7:18 PM, Andreas Roeseler wrote:
> Modify the icmp_rcv function to check PROBE messages and call icmp_echo
> if a PROBE request is detected.
> 


...

> @@ -1340,6 +1440,7 @@ static int __net_init icmp_sk_init(struct net *net)
>  
>  	/* Control parameters for ECHO replies. */
>  	net->ipv4.sysctl_icmp_echo_ignore_all = 0;
> +	net->ipv4.sysctl_icmp_echo_enable_probe = 0;
>  	net->ipv4.sysctl_icmp_echo_ignore_broadcasts = 1;
>  
>  	/* Control parameter - ignore bogus broadcast responses? */
> 

Where is sysctl_icmp_echo_enable_probe defined ?

Please include a cover letter, also add proper documentation for any new sysctl
in Documentation/networking/ip-sysctl.rst