netdev - Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cbb962675f646454f19e08e3c86e1b8ff09300c.camel@gmail.com>
Date:   Wed, 24 Mar 2021 15:24:51 -0500
From:   Andreas Roeseler <andreas.a.roeseler@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, yoshfuji@...ux-ipv6.org, dsahern@...nel.org,
        kuba@...nel.org
Subject: Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE
 messages

On Wed, 2021-03-24 at 20:47 +0100, Eric Dumazet wrote:
> 
> 
> On 3/24/21 7:18 PM, Andreas Roeseler wrote:
> > Modify the icmp_rcv function to check PROBE messages and call
> > icmp_echo
> > if a PROBE request is detected.
> > 
> 
> 
> ...
> 
> > @@ -1340,6 +1440,7 @@ static int __net_init icmp_sk_init(struct net
> > *net)
> >  
> >         /* Control parameters for ECHO replies. */
> >         net->ipv4.sysctl_icmp_echo_ignore_all = 0;
> > +       net->ipv4.sysctl_icmp_echo_enable_probe = 0;
> >         net->ipv4.sysctl_icmp_echo_ignore_broadcasts = 1;
> >  
> >         /* Control parameter - ignore bogus broadcast responses? */
> > 
> 
> Where is sysctl_icmp_echo_enable_probe defined ?

It is defined in patch 3 of this patchset.

> 
> Please include a cover letter, also add proper documentation for any
> new sysctl
> in Documentation/networking/ip-sysctl.rst
> 

Will do.