netdev - Re: [PATCH net-next v2 5/6] ethtool: fec: sanitize ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YF3RBg+xDHMi6YIB@lunn.ch>
Date:   Fri, 26 Mar 2021 13:18:14 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        ecree.xilinx@...il.com, michael.chan@...adcom.com,
        paul.greenwalt@...el.com, rajur@...lsio.com,
        jaroslawx.gawin@...el.com, vkochan@...vell.com, alobakin@...me,
        snelson@...sando.io, shayagr@...zon.com, ayal@...dia.com,
        shenjian15@...wei.com, saeedm@...dia.com, mkubecek@...e.cz,
        roopa@...dia.com
Subject: Re: [PATCH net-next v2 5/6] ethtool: fec: sanitize
 ethtool_fecparam->fec

On Thu, Mar 25, 2021 at 07:07:26PM -0700, Jakub Kicinski wrote:
> Reject NONE on set, this mode means device does not support
> FEC so it's a little out of place in the set interface.
> 
> This should be safe to do - user space ethtool does not allow
> the use of NONE on set. A few drivers treat it the same as OFF,
> but none use it instead of OFF.
> 
> Similarly reject an empty FEC mask. The common user space tool
> will not send such requests and most drivers correctly reject
> it already.
> 
> v2: - use mask not bit pos
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew