netdev - Re: [PATCH net-next v2 6/6] ethtool: clarify the ethtool FEC interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 13:20:28 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        ecree.xilinx@...il.com, michael.chan@...adcom.com,
        paul.greenwalt@...el.com, rajur@...lsio.com,
        jaroslawx.gawin@...el.com, vkochan@...vell.com, alobakin@...me,
        snelson@...sando.io, shayagr@...zon.com, ayal@...dia.com,
        shenjian15@...wei.com, saeedm@...dia.com, mkubecek@...e.cz,
        roopa@...dia.com
Subject: Re: [PATCH net-next v2 6/6] ethtool: clarify the ethtool FEC
 interface

On Thu, Mar 25, 2021 at 07:07:27PM -0700, Jakub Kicinski wrote:
> The definition of the FEC driver interface is quite unclear.
> Improve the documentation.
> 
> This is based on current driver and user space code, as well
> as the discussions about the interface:
> 
> RFC v1 (24 Oct 2016): https://lore.kernel.org/netdev/1477363849-36517-1-git-send-email-vidya@cumulusnetworks.com/
>  - this version has the autoneg field
>  - no active_fec field
>  - none vs off confusion is already present
> 
> RFC v2 (10 Feb 2017): https://lore.kernel.org/netdev/1486727004-11316-1-git-send-email-vidya@cumulusnetworks.com/
>  - autoneg removed
>  - active_fec added
> 
> v1 (10 Feb 2017): https://lore.kernel.org/netdev/1486751311-42019-1-git-send-email-vidya@cumulusnetworks.com/
>  - no changes in the code
> 
> v1 (24 Jun 2017):  https://lore.kernel.org/netdev/1498331985-8525-1-git-send-email-roopa@cumulusnetworks.com/
>  - include in tree user
> 
> v2 (27 Jul 2017): https://lore.kernel.org/netdev/1501199248-24695-1-git-send-email-roopa@cumulusnetworks.com/
> 
> v2: - make enum kdoc reference bits
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew