netdev - Re: [PATCH net-next v2 0/6] ethtool: clarify the ethtool FEC interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Mar 2021 14:49:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuba@...nel.org
Cc:     netdev@...r.kernel.org, ecree.xilinx@...il.com,
        michael.chan@...adcom.com, paul.greenwalt@...el.com,
        rajur@...lsio.com, jaroslawx.gawin@...el.com, vkochan@...vell.com,
        alobakin@...me, snelson@...sando.io, shayagr@...zon.com,
        ayal@...dia.com, shenjian15@...wei.com, saeedm@...dia.com,
        mkubecek@...e.cz, andrew@...n.ch, roopa@...dia.com
Subject: Re: [PATCH net-next v2 0/6] ethtool: clarify the ethtool FEC
 interface

From: Jakub Kicinski <kuba@...nel.org>
Date: Thu, 25 Mar 2021 19:07:21 -0700

> Our FEC configuration interface is one of the more confusing.
> It also lacks any error checking in the core. This certainly
> shows in the varying implementations across the drivers.
> 
> Improve the documentation and add most basic checks. Sadly, it's
> probably too late now to try to enforce much more uniformity.
> 
> Any thoughts & suggestions welcome. Next step is to add netlink
> for FEC, then stats.
> 
> v2: 
>  - fix patch 5
>  - adjust kdoc in patches 3 and 6

Jakub, I applied v1 so please send fiixups relative to that, thank you.