netdev - Re: [PATCH v4 bpf 0/3] AF_XDP Socket Creation Fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+LrOpP6WXrKkjdt6pVGoTsRs8SXLHxWQV6OO=GpZJhVQ@mail.gmail.com>
Date:   Thu, 1 Apr 2021 14:49:54 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Björn Töpel <bjorn@...nel.org>
Cc:     Ciara Loftus <ciara.loftus@...el.com>,
        Netdev <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>
Subject: Re: [PATCH v4 bpf 0/3] AF_XDP Socket Creation Fixes

On Wed, Mar 31, 2021 at 12:06 AM Björn Töpel <bjorn@...nel.org> wrote:
>
> On Wed, 31 Mar 2021 at 08:43, Ciara Loftus <ciara.loftus@...el.com> wrote:
> >
> > This series fixes some issues around socket creation for AF_XDP.
> >
> > Patch 1 fixes a potential NULL pointer dereference in
> > xsk_socket__create_shared.
> >
> > Patch 2 ensures that the umem passed to xsk_socket__create(_shared)
> > remains unchanged in event of failure.
> >
> > Patch 3 makes it possible for xsk_socket__create(_shared) to
> > succeed even if the rx and tx XDP rings have already been set up by
> > introducing a new fields to struct xsk_umem which represent the ring
> > setup status for the xsk which shares the fd with the umem.
> >
> > v3->v4:
> > * Reduced nesting in xsk_put_ctx as suggested by Alexei.
> > * Use bools instead of a u8 and flags to represent the
> >   ring setup status as suggested by Björn.
> >
>
> Thanks, Ciara! LGTM!
>
> Acked-by: Björn Töpel <bjorn@...nel.org>

Applied. Thanks