netdev - [PATCH bpf v2 0/2] bpf, sockmap fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <161731427139.68884.1934993103507544474.stgit@john-XPS-13-9370>
Date:   Thu, 01 Apr 2021 14:59:58 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     xiyou.wangcong@...il.com, andrii.nakryiko@...il.com,
        daniel@...earbox.net, ast@...com
Cc:     john.fastabend@...il.com, bpf@...r.kernel.org,
        netdev@...r.kernel.org, lmb@...udflare.com
Subject: [PATCH bpf v2 0/2] bpf, sockmap fixes

This addresses an issue found while reviewing latest round of sock
map patches and an issue reported from CI via Andrii. After this
CI ./test_maps is stable for me.

The CI discovered issue was introduced by over correcting our
previously broken memory accounting. After the fix, "bpf, sockmap:
Avoid returning unneeded EAGAIN when redirecting to self" we fixed
a dropped packet and a missing fwd_alloc calculations, but pushed
it too far back into the packet pipeline creating an issue in the
unlikely case socket tear down happens with an enqueued skb. See
patch for details.

Tested with usual suspects: test_sockmap, test_maps, test_progs
and test_progs-no_alu32.

v2: drop skb_orphan its not necessary and use sk directly instead
    of using psock->sk both suggested by Cong

---

John Fastabend (2):
      bpf, sockmap: fix sk->prot unhash op reset
      bpf, sockmap: fix incorrect fwd_alloc accounting

 net/core/skmsg.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

--