netdev - Re: [PATCH net-next v2 2/3] dpaa2-eth: add rx copybreak support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YGcP0Uz5CfCwv5ev@lunn.ch>
Date:   Fri, 2 Apr 2021 14:36:33 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ioana Ciornei <ciorneiioana@...il.com>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        ruxandra.radulescu@....com, Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next v2 2/3] dpaa2-eth: add rx copybreak support

On Fri, Apr 02, 2021 at 12:55:31PM +0300, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@....com>
> 
> DMA unmapping, allocating a new buffer and DMA mapping it back on the
> refill path is really not that efficient. Proper buffer recycling (page
> pool, flipping the page and using the other half) cannot be done for
> DPAA2 since it's not a ring based controller but it rather deals with
> multiple queues which all get their buffers from the same buffer pool on
> Rx.
> 
> To circumvent these limitations, add support for Rx copybreak. For small
> sized packets instead of creating a skb around the buffer in which the
> frame was received, allocate a new sk buffer altogether, copy the
> contents of the frame and release the initial page back into the buffer
> pool.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew