netdev - RE: [EXT] [PATCH 1/2] qede: Remove a erroneous ++ in 'qede_rx_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB3388733FA76041D09B546CA8AB779@DM6PR18MB3388.namprd18.prod.outlook.com>
Date:   Mon, 5 Apr 2021 10:01:19 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [EXT] [PATCH 1/2] qede: Remove a erroneous ++ in
 'qede_rx_build_jumbo()'

> -----Original Message-----
> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Sent: Sunday, April 4, 2021 6:13 PM
> To: Ariel Elior <aelior@...vell.com>; GR-everest-linux-l2 <GR-everest-linux-
> l2@...vell.com>; davem@...emloft.net; kuba@...nel.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-
> janitors@...r.kernel.org; Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Subject: [EXT] [PATCH 1/2] qede: Remove a erroneous ++ in
> 'qede_rx_build_jumbo()'
> 
> External Email
> 
> ----------------------------------------------------------------------
> This ++ is confusing. It looks duplicated with the one already performed in
> 'skb_fill_page_desc()'.
> 
> In fact, it is harmless. 'nr_frags' is written twice with the same value.
> Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1'
> in 'skb_fill_page_desc()'.
> 
> So axe this post-increment to avoid confusion.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/qlogic/qede/qede_fp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> index 102d0e0808d5..ee3e45e38cb7 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> @@ -1209,7 +1209,7 @@ static int qede_rx_build_jumbo(struct qede_dev
> *edev,
>  		dma_unmap_page(rxq->dev, bd->mapping,
>  			       PAGE_SIZE, DMA_FROM_DEVICE);
> 
> -		skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++,
> +		skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
>  				   bd->data, rxq->rx_headroom, cur_size);
> 
>  		skb->truesize += PAGE_SIZE;
> --
> 2.27.0

Acked-by: Manish Chopra <manishc@...vell.com>