netdev - Re: [PATCH] batman-adv: initialize "struct batadv_tvlv_tt_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Apr 2021 19:02:02 +0900
From:   Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:     Sven Eckelmann <sven@...fation.org>,
        Marek Lindner <mareklindner@...mailbox.ch>,
        Simon Wunderlich <sw@...onwunderlich.de>,
        Antonio Quartulli <a@...table.cc>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] batman-adv: initialize "struct
 batadv_tvlv_tt_vlan_data"->reserved field

On 2021/04/05 16:39, Sven Eckelmann wrote:
> On Monday, 5 April 2021 07:33:06 CEST Tetsuo Handa wrote:
> [...]
>> ---
>>  net/batman-adv/translation-table.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
>> index f8761281aab0..eb82576557e6 100644
>> --- a/net/batman-adv/translation-table.c
>> +++ b/net/batman-adv/translation-table.c
>> @@ -973,6 +973,7 @@ batadv_tt_prepare_tvlv_local_data(struct batadv_priv *bat_priv,
>>  
>>  		tt_vlan->vid = htons(vlan->vid);
>>  		tt_vlan->crc = htonl(vlan->tt.crc);
>> +		tt_vlan->reserved = 0;
>>  
>>  		tt_vlan++;
>>  	}
>>
> 
> Thanks but this patch is incomplete. Please also fix 
> batadv_tt_prepare_tvlv_global_data (exactly the same way)

Indeed. Hmm, batadv_send_tt_request() is already using kzalloc().
Which approach ( "->reserved = 0" or "kzalloc()") do you prefer for
batadv_tt_prepare_tvlv_global_data() and batadv_tt_prepare_tvlv_local_data() ?

> 
> Kind regards,
> 	Sven
>