netdev - Re: [PATCH net v1 1/1] ethtool: fix incorrect datatype in set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210406115402.373ba332@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 6 Apr 2021 11:54:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Wong Vee Khee <vee.khee.wong@...ux.intel.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Michal Kubecek <mkubecek@...e.cz>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net v1 1/1] ethtool: fix incorrect datatype in set_eee
 ops

On Tue,  6 Apr 2021 21:17:30 +0800 Wong Vee Khee wrote:
> The member 'tx_lpi_timer' is defined with __u32 datatype in the ethtool
> header file. Hence, we should use ethnl_update_u32() in set_eee ops.
> 
> Fixes: fd77be7bd43c ("ethtool: set EEE settings with EEE_SET request")
> Cc: <stable@...r.kernel.org> # 5.10.x
> Cc: Michal Kubecek <mkubecek@...e.cz>
> Signed-off-by: Wong Vee Khee <vee.khee.wong@...ux.intel.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>