netdev - Re: [PATCH net v2 2/3] net: sched: fix action overwrite reference counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c84d6349-ec97-9ee7-12d7-544677c4ec8f@mojatatu.com>
Date:   Thu, 8 Apr 2021 09:43:25 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Vlad Buslov <vladbu@...dia.com>,
        Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Kumar Kartikeya Dwivedi <memxor@...il.com>,
        David Miller <davem@...emloft.net>,
        Jiri Pirko <jiri@...nulli.us>,
        Jakub Kicinski <kuba@...nel.org>,
        Toke Høiland-Jørgensen 
        <toke@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH net v2 2/3] net: sched: fix action overwrite reference
 counting

On 2021-04-08 3:50 a.m., Vlad Buslov wrote:
> 
> On Thu 08 Apr 2021 at 02:50, Cong Wang <xiyou.wangcong@...il.com> wrote:

> Origins of setting ovr based on NLM_F_REPLACE are lost since this code
> goes back to Linus' Linux-2.6.12-rc2 commit. Jamal, do you know if this
> is the expected behavior or just something unintended?

Seems our emails crossed path. The problem with ovr is the ambiguity
of whether we are saying both CREATE and REPLACE or just one or the
other. We could improve the kernel side by just passing the flags
to each action. Note it is too late to fix iproute2 without some
backward compat flag; but it may not be too late for someone writting
a new application in user space.

cheers,
jamal