netdev - Re: [PATCH net-next] ethtool: Move __ethtool_get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YG8KAOtjkpNuEPkN@lunn.ch>
Date:   Thu, 8 Apr 2021 15:49:52 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Danielle Ratson <danieller@...dia.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        alobakin@...me, meirl@...lanox.com, dmurphy@...com,
        mkubecek@...e.cz, f.fainelli@...il.com, irusskikh@...vell.com,
        alexanderduyck@...com, magnus.karlsson@...el.com,
        ecree@...arflare.com, idosch@...dia.com, jiri@...dia.com,
        mlxsw@...dia.com
Subject: Re: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to
 common file

On Thu, Apr 08, 2021 at 01:58:13PM +0300, Danielle Ratson wrote:
> __ethtool_get_link_ksettings() function is shared by both ioctl and
> netlink ethtool interfaces.
> 
> Move it to net/ethtool/common.c file, which is the suitable place for
> a shared code.
> 
> Signed-off-by: Danielle Ratson <danieller@...dia.com>
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>

Seems sensible.

Did you look to see what else is shared and should move? Rather than
doing it one function at a time, can we do it all at once?

    Andrew