netdev - RE: [PATCH net-next] ethtool: Move __ethtool_get_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR12MB451615D959313E7675C3AEF8D8469@DM6PR12MB4516.namprd12.prod.outlook.com>
Date:   Thu, 22 Apr 2021 15:38:18 +0000
From:   Danielle Ratson <danieller@...dia.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "alobakin@...me" <alobakin@...me>,
        Meir Lichtinger <meirl@...dia.com>,
        "dmurphy@...com" <dmurphy@...com>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "irusskikh@...vell.com" <irusskikh@...vell.com>,
        "alexanderduyck@...com" <alexanderduyck@...com>,
        "magnus.karlsson@...el.com" <magnus.karlsson@...el.com>,
        "ecree@...arflare.com" <ecree@...arflare.com>,
        Ido Schimmel <idosch@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        mlxsw <mlxsw@...dia.com>
Subject: RE: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to
 common file



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Thursday, April 8, 2021 4:50 PM
> To: Danielle Ratson <danieller@...dia.com>
> Cc: netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org; alobakin@...me; Meir Lichtinger <meirl@...dia.com>;
> dmurphy@...com; mkubecek@...e.cz; f.fainelli@...il.com; irusskikh@...vell.com; alexanderduyck@...com;
> magnus.karlsson@...el.com; ecree@...arflare.com; Ido Schimmel <idosch@...dia.com>; Jiri Pirko <jiri@...dia.com>; mlxsw
> <mlxsw@...dia.com>
> Subject: Re: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file
> 
> On Thu, Apr 08, 2021 at 01:58:13PM +0300, Danielle Ratson wrote:
> > __ethtool_get_link_ksettings() function is shared by both ioctl and
> > netlink ethtool interfaces.
> >
> > Move it to net/ethtool/common.c file, which is the suitable place for
> > a shared code.
> >
> > Signed-off-by: Danielle Ratson <danieller@...dia.com>
> > Suggested-by: Jakub Kicinski <kuba@...nel.org>
> > Reviewed-by: Ido Schimmel <idosch@...dia.com>
> > Reviewed-by: Jiri Pirko <jiri@...dia.com>
> 
> Seems sensible.
> 
> Did you look to see what else is shared and should move? Rather than doing it one function at a time, can we do it all at once?
> 
>     Andrew

This is the only one I found that needs to be moved, thanks.