netdev - RE: [Intel-wired-lan] [PATCH] i40e: The state of phy may not be correct during power-on

Open Source and information security mailing list archives

Message-ID: <DM6PR11MB4657EB5A8040E7D5A9CB155E9B739@DM6PR11MB4657.namprd11.prod.outlook.com>
Date:   Fri, 9 Apr 2021 18:12:35 +0000
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To:     "xiao33522@...com" <xiao33522@...com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        xiaolinkui <xiaolinkui@...inos.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH] i40e: The state of phy may not be
 correct during power-on

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of xiao33522@...com
>Sent: piątek, 9 kwietnia 2021 11:18
>To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>
>Cc: netdev@...r.kernel.org; xiaolinkui <xiaolinkui@...inos.cn>; linux-kernel@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; kuba@...nel.org; davem@...emloft.net
>Subject: [Intel-wired-lan] [PATCH] i40e: The state of phy may not be correct during power-on
>
>From: xiaolinkui <xiaolinkui@...inos.cn>
>
>Sometimes the power on state of the x710 network card indicator is not right, and the indicator shows orange. At this time, the network card speed is Gigabit.

By "power on state" you mean that it happens after power-up of the server?

>
>After entering the system, check the network card status through the ethtool command as follows:
>
>[root@...alhost ~]# ethtool enp132s0f0
>Settings for enp132s0f0:
>	Supported ports: [ FIBRE ]
>	Supported link modes:   1000baseX/Full
>	                        10000baseSR/Full
>	Supported pause frame use: Symmetric
>	Supports auto-negotiation: Yes
>	Supported FEC modes: Not reported
>	Advertised link modes:  1000baseX/Full
>	                        10000baseSR/Full
>	Advertised pause frame use: No
>	Advertised auto-negotiation: Yes
>	Advertised FEC modes: Not reported
>	Speed: 1000Mb/s
>	Duplex: Full
>	Port: FIBRE
>	PHYAD: 0
>	Transceiver: internal
>	Auto-negotiation: off
>	Supports Wake-on: d
>	Wake-on: d
>	Current message level: 0x00000007 (7)
>			       drv probe link
>	Link detected: yes
>
>We can see that the speed is 1000Mb/s.
>
>If you unplug and plug in the optical cable, it can be restored to 10g.
>After this operation, the rate is as follows:
>
>[root@...alhost ~]# ethtool enp132s0f0
>Settings for enp132s0f0:
>        Supported ports: [ FIBRE ]
>        Supported link modes:   1000baseX/Full
>                                10000baseSR/Full
>        Supported pause frame use: Symmetric
>        Supports auto-negotiation: Yes
>        Supported FEC modes: Not reported
>        Advertised link modes:  1000baseX/Full
>                                10000baseSR/Full
>        Advertised pause frame use: No
>        Advertised auto-negotiation: Yes
>        Advertised FEC modes: Not reported
>        Speed: 10000Mb/s
>        Duplex: Full
>        Port: FIBRE
>        PHYAD: 0
>        Transceiver: internal
>        Auto-negotiation: off
>        Supports Wake-on: d
>        Wake-on: d
>        Current message level: 0x00000007 (7)
>                               drv probe link
>        Link detected: yes
>
>Calling i40e_aq_set_link_restart_an can also achieve this function.
>So we need to do a reset operation for the network card when the network card status is abnormal.

Can't say much about the root cause of the issue right now,
but I don't think it is good idea for the fix.
This leads to braking existing link each time 
i40e_aq_get_link_info is called on 1 Gigabit PHY.
For example 'ethtool -m <dev>' does that.

Have you tried reloading the driver?
Thanks!

>
>Signed-off-by: xiaolinkui <xiaolinkui@...inos.cn>
>---
> drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c
>index ec19e18305ec..dde0224776ac 100644
>--- a/drivers/net/ethernet/intel/i40e/i40e_common.c
>+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c
>@@ -1866,6 +1866,10 @@ i40e_status i40e_aq_get_link_info(struct i40e_hw *hw,
> 	hw_link_info->max_frame_size = le16_to_cpu(resp->max_frame_size);
> 	hw_link_info->pacing = resp->config & I40E_AQ_CONFIG_PACING_MASK;
> 
>+	if (hw_link_info->phy_type == I40E_PHY_TYPE_1000BASE_SX &&
>+	    hw->mac.type == I40E_MAC_XL710)
>+		i40e_aq_set_link_restart_an(hw, true, NULL);
>+
> 	/* update fc info */
> 	tx_pause = !!(resp->an_info & I40E_AQ_LINK_PAUSE_TX);
> 	rx_pause = !!(resp->an_info & I40E_AQ_LINK_PAUSE_RX);
>--
>2.17.1
>
>_______________________________________________
>Intel-wired-lan mailing list
>Intel-wired-lan@...osl.org
>https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives