netdev - Re: [PATCH net-next 2/2] ibmvnic: add sysfs entry for timeout and fatal reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOhMmr5H_0QuSwOU-FEBQb3CHegSi4f3hdtEtprKKF7i1WebEw@mail.gmail.com>
Date:   Mon, 12 Apr 2021 15:26:00 -0500
From:   Lijun Pan <lijunp213@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] ibmvnic: add sysfs entry for timeout and
 fatal reset

On Mon, Apr 12, 2021 at 1:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 12 Apr 2021 02:43:30 -0500 Lijun Pan wrote:
> > Add timeout and fatal reset sysfs entries so that both functions
> > can be triggered manually the tested. Otherwise, you have to run
> > the program for enough time and check both randomly generated
> > resets in the long long log.
>
> This looks more suitable for debugfs.
>
> But can't you use ethtool or devlink reset functionality somehow?

ethtool and devlink reset seem better to be implemented by a FAILVOER reset for
this driver. ethtool/devlink reset are not implemented in this driver,
which will be a todo list for me.

This timeout reset can be triggered by tx watchdog,
.ndo_tx_timeout->ibmvnic_tx_timeout->ibmvnic_reset(adapter, VNIC_RESET_TIMEOUT);
Do you know is there a way to trigger that ndo_tx_timeout from some
user space tool?

The FATAL reset is triggered by Firmware, quite specific for this driver.
So in order to verify that, I put it in sysfs entry.