netdev - Re: [net] tls/chtls: fix kernel panic with tls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210413112114.2461b7a3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 13 Apr 2021 11:21:14 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Rohit Maheshwari <rohitm@...lsio.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        john.fastabend@...il.com, borisp@...dia.com, secdev@...lsio.com,
        Vinay Kumar Yadav <vinay.yadav@...lsio.com>
Subject: Re: [net] tls/chtls: fix kernel panic with tls_toe

On Tue, 13 Apr 2021 16:14:47 +0530 Rohit Maheshwari wrote:
> If tls_toe is supported by any device, tls_toe will be enabled
> and tls context will be created for listen sockets. But the
> connections established in stack issue context delete for every
> connection close, this causes kernel panic.
>   As part of the fix, if tls_toe is supported, don't initialize
> tcp_ulp_ops. Also make sure tls context is freed only for listen
> sockets.

Still nack. Kernel TLS does not work on listening sockets, 
so the bug is that the offload TOE TLS does. Offloaded and 
non-offload TLS should be the same from uAPI perspective.