netdev - Re: [PATCH net-next v4 01/10] netdevice: priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Apr 2021 14:30:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>
Subject: Re: [PATCH net-next v4 01/10] netdevice: priv_flags extend to 64bit

Hi Xuan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210413-111831
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8ef7adc6beb2ef0bce83513dc9e4505e7b21e8c2
config: x86_64-randconfig-a014-20210413 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/32403bd72dd27e9d773cfce22af2e46aeec0a3b1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210413-111831
        git checkout 32403bd72dd27e9d773cfce22af2e46aeec0a3b1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/8021q/vlanproc.c:257:30: warning: format specifies type 'unsigned short' but the argument has type 'netdev_priv_flags_t' (aka 'unsigned long long') [-Wformat]
                      (int)(vlan->flags & 1), vlandev->priv_flags);
                                              ^~~~~~~~~~~~~~~~~~~
   net/8021q/vlanproc.c:284:22: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                                      mp->priority, ((mp->vlan_qos >> 13) & 0x7));
                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +257 net/8021q/vlanproc.c

^1da177e4c3f41 Linus Torvalds  2005-04-16  240  
^1da177e4c3f41 Linus Torvalds  2005-04-16  241  static int vlandev_seq_show(struct seq_file *seq, void *offset)
^1da177e4c3f41 Linus Torvalds  2005-04-16  242  {
^1da177e4c3f41 Linus Torvalds  2005-04-16  243  	struct net_device *vlandev = (struct net_device *) seq->private;
7da82c06ded105 Jiri Pirko      2011-12-08  244  	const struct vlan_dev_priv *vlan = vlan_dev_priv(vlandev);
28172739f0a276 Eric Dumazet    2010-07-07  245  	struct rtnl_link_stats64 temp;
be1f3c2c027cc5 Ben Hutchings   2010-06-08  246  	const struct rtnl_link_stats64 *stats;
be1f3c2c027cc5 Ben Hutchings   2010-06-08  247  	static const char fmt64[] = "%30s %12llu\n";
^1da177e4c3f41 Linus Torvalds  2005-04-16  248  	int i;
^1da177e4c3f41 Linus Torvalds  2005-04-16  249  
26a25239d7a660 Joonwoo Park    2008-07-08  250  	if (!is_vlan_dev(vlandev))
^1da177e4c3f41 Linus Torvalds  2005-04-16  251  		return 0;
^1da177e4c3f41 Linus Torvalds  2005-04-16  252  
28172739f0a276 Eric Dumazet    2010-07-07  253  	stats = dev_get_stats(vlandev, &temp);
2029cc2c84fb11 Patrick McHardy 2008-01-21  254  	seq_printf(seq,
2029cc2c84fb11 Patrick McHardy 2008-01-21  255  		   "%s  VID: %d	 REORDER_HDR: %i  dev->priv_flags: %hx\n",
7da82c06ded105 Jiri Pirko      2011-12-08  256  		   vlandev->name, vlan->vlan_id,
7da82c06ded105 Jiri Pirko      2011-12-08 @257  		   (int)(vlan->flags & 1), vlandev->priv_flags);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (36433 bytes)