netdev - RE: [net-next] enetc: fix locking for one-step timestamping packet transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM7PR04MB68858CD679FCD7F0BBE41E20F84D9@AM7PR04MB6885.eurprd04.prod.outlook.com>
Date:   Thu, 15 Apr 2021 05:33:34 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Russell King <linux@...linux.org.uk>
Subject: RE: [net-next] enetc: fix locking for one-step timestamping packet
 transfer



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: 2021年4月15日 0:36
> To: Y.b. Lu <yangbo.lu@....com>
> Cc: netdev@...r.kernel.org; David S . Miller <davem@...emloft.net>; Richard
> Cochran <richardcochran@...il.com>; Claudiu Manoil
> <claudiu.manoil@....com>; Vladimir Oltean <vladimir.oltean@....com>;
> Russell King <linux@...linux.org.uk>
> Subject: Re: [net-next] enetc: fix locking for one-step timestamping packet
> transfer
> 
> On Wed, 14 Apr 2021 06:18:57 +0000 Y.b. Lu wrote:
> > > On Tue, 13 Apr 2021 11:48:17 +0800 Yangbo Lu wrote:
> > > > +	/* Queue one-step Sync packet if already locked */
> > > > +	if (skb->cb[0] & ENETC_F_TX_ONESTEP_SYNC_TSTAMP) {
> > > > +		if
> > > (test_and_set_bit_lock(ENETC_TX_ONESTEP_TSTAMP_IN_PROGRESS,
> > > > +					  &priv->flags)) {
> > > > +			skb_queue_tail(&priv->tx_skbs, skb);
> > > > +			return NETDEV_TX_OK;
> > > > +		}
> > > > +	}
> > >
> > > Isn't this missing queue_work() as well?
> > >
> > > Also as I mentioned I don't understand why you created a separate
> > > workqueue instead of using the system workqueue via schedule_work().
> >
> > queue_work(system_wq, ) was put in clean_tx. I finally followed the
> > logic you suggested :)
> 
> Ah, I didn't look close enough. I was expecting to see schedule_work(), please
> consider sending a follow up, queue_work(system_wq, $work) is a rare
> construct.

Thank you Jakub. I sent another patch for this.
https://patchwork.kernel.org/project/netdevbpf/patch/20210415053455.10029-1-yangbo.lu@nxp.com/