netdev - RE: [net-next] enetc: fix locking for one-step timestamping packet transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM7PR04MB68858E23D828E7C24581EE3AF8489@AM7PR04MB6885.eurprd04.prod.outlook.com>
Date:   Tue, 20 Apr 2021 04:41:32 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "David S . Miller" <davem@...emloft.net>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Jakub Kicinski <kuba@...nel.org>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Russell King <linux@...linux.org.uk>
Subject: RE: [net-next] enetc: fix locking for one-step timestamping packet
 transfer

Hi,

I think this patch was reviewed and no objection now, right? (I see status is " Changes Requested ".)
Thanks.

> -----Original Message-----
> From: Yangbo Lu <yangbo.lu@....com>
> Sent: 2021年4月13日 11:48
> To: netdev@...r.kernel.org
> Cc: Y.b. Lu <yangbo.lu@....com>; David S . Miller <davem@...emloft.net>;
> Richard Cochran <richardcochran@...il.com>; Claudiu Manoil
> <claudiu.manoil@....com>; Jakub Kicinski <kuba@...nel.org>; Vladimir
> Oltean <vladimir.oltean@....com>; Russell King <linux@...linux.org.uk>
> Subject: [net-next] enetc: fix locking for one-step timestamping packet transfer
> 
> The previous patch to support PTP Sync packet one-step timestamping
> described one-step timestamping packet handling logic as below in commit
> message:
> 
> - Trasmit packet immediately if no other one in transfer, or queue to
>   skb queue if there is already one in transfer.
>   The test_and_set_bit_lock() is used here to lock and check state.
> - Start a work when complete transfer on hardware, to release the bit
>   lock and to send one skb in skb queue if has.
> 
> There was not problem of the description, but there was a mistake in
> implementation. The locking/test_and_set_bit_lock() should be put in
> enetc_start_xmit() which may be called by worker, rather than in enetc_xmit().
> Otherwise, the worker calling enetc_start_xmit() after bit lock released is not
> able to lock again for transfer.
> 
> Fixes: 7294380c5211 ("enetc: support PTP Sync packet one-step
> timestamping")
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>
[...]