netdev - Re: [PATCH net-next 00/18] devlink: rate objects API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210421115955.5c7fee82@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 21 Apr 2021 11:59:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Dmytro Linkin <dlinkin@...dia.com>
Cc:     <netdev@...r.kernel.org>, <davem@...emloft.net>, <jiri@...dia.com>
Subject: Re: [PATCH net-next 00/18] devlink: rate objects API

On Wed, 21 Apr 2021 15:08:07 +0300 Dmytro Linkin wrote:
> On 4/20/21 11:35 PM, Jakub Kicinski wrote:
> > On Tue, 20 Apr 2021 14:33:36 +0300 dlinkin@...dia.com wrote:  
> >> From: Dmytro Linkin <dlinkin@...dia.com>
> >>
> >> Currently kernel provides a way to change tx rate of single VF in
> >> switchdev mode via tc-police action. When lots of VFs are configured
> >> management of theirs rates becomes non-trivial task and some grouping
> >> mechanism is required. Implementing such grouping in tc-police will bring
> >> flow related limitations and unwanted complications, like:
> >> - flows requires net device to be placed on  
> > 
> > Meaning they are only usable in "switchdev mode"?  
> 
> Meaning, "groups" wouldn't have corresponding net devices and needs
> somehow to deal with that. I'll rephrase this line.

But you can share a police action across netdevs. A deeper analysis of
the capabilities of the current subsystem would be appreciated before
we commit to this (less expressive) implementation.