netdev - Re: [PATCH net-next 00/18] devlink: rate objects API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 11:05:04 +0300
From:   Dmytro Linkin <dlinkin@...dia.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>, <jiri@...dia.com>
Subject: Re: [PATCH net-next 00/18] devlink: rate objects API

On 4/21/21 9:59 PM, Jakub Kicinski wrote:
> On Wed, 21 Apr 2021 15:08:07 +0300 Dmytro Linkin wrote:
>> On 4/20/21 11:35 PM, Jakub Kicinski wrote:
>>> On Tue, 20 Apr 2021 14:33:36 +0300 dlinkin@...dia.com wrote:  
>>>> From: Dmytro Linkin <dlinkin@...dia.com>
>>>>
>>>> Currently kernel provides a way to change tx rate of single VF in
>>>> switchdev mode via tc-police action. When lots of VFs are configured
>>>> management of theirs rates becomes non-trivial task and some grouping
>>>> mechanism is required. Implementing such grouping in tc-police will bring
>>>> flow related limitations and unwanted complications, like:
>>>> - flows requires net device to be placed on  
>>>
>>> Meaning they are only usable in "switchdev mode"?  
>>
>> Meaning, "groups" wouldn't have corresponding net devices and needs
>> somehow to deal with that. I'll rephrase this line.
> 
> But you can share a police action across netdevs. A deeper analysis of
> the capabilities of the current subsystem would be appreciated before
> we commit to this (less expressive) implementation.
> 

Hi, Sorry for a delay in answering.

We have a customer request for a traffic shaper for a group of VFs.
tc-police action is a policer, so shared action isn't suitable. Since
request was more about group shaper, was reviewed a case when
representor have a policer and the driver will use a shaper if qdisc
action is continue and qdisc contains group of vf – but such approach
ugly, complicated and misleading.
Also TC is ingress only, while configuring "other" side of the wire
looks more like a “real” picture where shaping is outside of steering world.