netdev - Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinRRcoaxsiHZyYcywgRtOs0E5hJdQ0gjHPAj3991gMzHw@mail.gmail.com>
Date:   Mon, 26 Apr 2021 09:35:47 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features_check().

On Mon, Apr 26, 2021 at 9:29 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Sun, 25 Apr 2021 13:45:27 -0400 Michael Chan wrote:
> > +     if (l4_proto != IPPROTO_UDP)
> > +             return features;
>
> This should have been "features & ~(CSUM | GSO)" if you actually
> accepted my feedback. I mentioned extension headers as an example,
> v2 looks like a minor refactoring, no functional changes :/
>
> > +     bp = netdev_priv(dev);
> > +     /* For UDP, we can only handle 1 Vxlan port and 1 Geneve port. */
> > +     udp_port = udp_hdr(skb)->dest;
> > +     if (udp_port == bp->vxlan_port || udp_port == bp->nge_port)
> > +             return features;
> > +     return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK);

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)