netdev - Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimdhTTD-vmfjkFDME_uHUBZTEMbUgA0WvSzjhPMjOPn_w@mail.gmail.com>
Date:   Mon, 26 Apr 2021 09:45:17 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Andrew Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net-next v2 10/10] bnxt_en: Implement .ndo_features_check().

On Mon, Apr 26, 2021 at 9:35 AM Michael Chan <michael.chan@...adcom.com> wrote:
>
> On Mon, Apr 26, 2021 at 9:29 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Sun, 25 Apr 2021 13:45:27 -0400 Michael Chan wrote:
> > > +     if (l4_proto != IPPROTO_UDP)
> > > +             return features;
> >
> > This should have been "features & ~(CSUM | GSO)" if you actually
> > accepted my feedback.

Sorry, hit send too early.  If it is not UDP, it could be GRE or IP
over IP for example, right?  Why do we need to turn off offload?

> I mentioned extension headers as an example,

Extension headers (Geneve for example) are supported.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)