netdev - Re: [PATCH] net: hso: fix NULL-deref on disconnect regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YIaJcgmiJFERvbEF@hovoldconsulting.com>
Date:   Mon, 26 Apr 2021 11:35:46 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Leonardo Antoniazzi <leoanto@...ba.it>
Cc:     linux-usb@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Anirudh Rayabharam <mail@...rudhrb.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hso: fix NULL-deref on disconnect regression

On Mon, Apr 26, 2021 at 11:29:11AM +0200, Leonardo Antoniazzi wrote:
> On Mon, 26 Apr 2021 10:11:49 +0200
> Johan Hovold <johan@...nel.org> wrote:
> 
> > Commit 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device
> > unregistration") fixed the racy minor allocation reported by syzbot, but
> > introduced an unconditional NULL-pointer dereference on every disconnect
> > instead.
> > 
> > Specifically, the serial device table must no longer be accessed after
> > the minor has been released by hso_serial_tty_unregister().
> > 
> > Fixes: 8a12f8836145 ("net: hso: fix null-ptr-deref during tty device unregistration")
> > Cc: stable@...r.kernel.org
> > Cc: Anirudh Rayabharam <mail@...rudhrb.com>
> > Reported-by: Leonardo Antoniazzi <leoanto@...ba.it>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > ---

> the patch fix the problem

Thanks for confirming.

Next time, please keep the CC list intact when replying so that everyone
sees that you've tested it.

Johan