netdev - Re: [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Apr 2021 17:43:49 +0800
From:   David Wu <david.wu@...k-chips.com>
To:     Ezequiel Garcia <ezequiel@...labora.com>, netdev@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org
Cc:     Jose Abreu <joabreu@...opsys.com>,
        Heiko Stuebner <heiko@...ech.de>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Peter Geis <pgwipeout@...il.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        Rob Herring <robh+dt@...nel.org>,
        Johan Jonker <jbx6244@...il.com>, kernel@...labora.com
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in
 rk3328.dtsi

Hi Ezequiel,

在 2021/4/26 上午10:41, Ezequiel Garcia 写道:
> Rockchip DWMAC glue driver uses the phy node (phy-handle)
> reset specifier, and not a "mac-phy" reset specifier.
> 
> Remove it.
> 

Well done, the "mac-phy" reset is not part of the controller. So

Reviewed-by: David Wu <david.wu@...k-chips.com>

> Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3328.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index 5bab61784735..3ed69ecbcf3c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -916,8 +916,8 @@ gmac2phy: ethernet@...50000 {
>   			      "mac_clk_tx", "clk_mac_ref",
>   			      "aclk_mac", "pclk_mac",
>   			      "clk_macphy";
> -		resets = <&cru SRST_GMAC2PHY_A>, <&cru SRST_MACPHY>;
> -		reset-names = "stmmaceth", "mac-phy";
> +		resets = <&cru SRST_GMAC2PHY_A>;
> +		reset-names = "stmmaceth";
>   		phy-mode = "rmii";
>   		phy-handle = <&phy>;
>   		snps,txpbl = <0x4>;
>