netdev - Re: [PATCH 2/3] dt-bindings: net: dwmac: Add Rockchip DWMAC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Apr 2021 17:49:47 +0800
From:   David Wu <david.wu@...k-chips.com>
To:     Ezequiel Garcia <ezequiel@...labora.com>, netdev@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org
Cc:     Jose Abreu <joabreu@...opsys.com>,
        Heiko Stuebner <heiko@...ech.de>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Peter Geis <pgwipeout@...il.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        Rob Herring <robh+dt@...nel.org>,
        Johan Jonker <jbx6244@...il.com>, kernel@...labora.com
Subject: Re: [PATCH 2/3] dt-bindings: net: dwmac: Add Rockchip DWMAC support

Hi Ezequiel,

Good work,  this is what I plan to do.
Thank you.

Reviewed-by: David Wu <david.wu@...k-chips.com>

在 2021/4/26 上午10:41, Ezequiel Garcia 写道:
> Add Rockchip DWMAC controllers, which are based on snps,dwmac.
> Some of the SoCs require up to eight clocks, so maxItems
> for clocks and clock-names need to be increased.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
> ---
>   .../devicetree/bindings/net/snps,dwmac.yaml         | 13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 0642b0f59491..2edd8bea993e 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -56,6 +56,15 @@ properties:
>           - amlogic,meson8m2-dwmac
>           - amlogic,meson-gxbb-dwmac
>           - amlogic,meson-axg-dwmac
> +        - rockchip,px30-gmac
> +        - rockchip,rk3128-gmac
> +        - rockchip,rk3228-gmac
> +        - rockchip,rk3288-gmac
> +        - rockchip,rk3328-gmac
> +        - rockchip,rk3366-gmac
> +        - rockchip,rk3368-gmac
> +        - rockchip,rk3399-gmac
> +        - rockchip,rv1108-gmac
>           - snps,dwmac
>           - snps,dwmac-3.50a
>           - snps,dwmac-3.610
> @@ -89,7 +98,7 @@ properties:
>   
>     clocks:
>       minItems: 1
> -    maxItems: 5
> +    maxItems: 8
>       additionalItems: true
>       items:
>         - description: GMAC main clock
> @@ -101,7 +110,7 @@ properties:
>   
>     clock-names:
>       minItems: 1
> -    maxItems: 5
> +    maxItems: 8
>       additionalItems: true
>       contains:
>         enum:
>