netdev - Re: [PATCH 1/1] net: phy: marvell: enable downshift by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb3efe41-85f5-c57f-1293-0f6fbf610ed6@inbox.ru>
Date:   Thu, 29 Apr 2021 06:52:08 +0300
From:   Maxim Kochetkov <fido_max@...ox.ru>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, hkallweit1@...il.com,
        linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org,
        f.fainelli@...il.com
Subject: Re: [PATCH 1/1] net: phy: marvell: enable downshift by default

28.04.2021 22:30, Andrew Lunn wrote:
> On Wed, Apr 28, 2021 at 03:48:53PM +0300, Maxim Kochetkov wrote:
>> Enable downshift for all supported PHYs by default like 88E1116R does.
> 
> There are two different mechanisms to set to downshift. And i think
> some of the older PHYs don't support it at all. How did you decide on
> which method to use for each PHY?
> 
>        Andrew
> 

When I said "For all supported PHYs" I mean PHYs whith set_phy_tunable 
defined. So I just added appropriate call of set_downshift found at 
m88*_set_tunable functions to config_init of each PHY with 
set_phy_tunable defined.