netdev - Re: [PATCH 1/1] net: phy: marvell: enable downshift by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YIsqNMYKD0gsg/q5@lunn.ch>
Date:   Thu, 29 Apr 2021 23:50:44 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Maxim Kochetkov <fido_max@...ox.ru>
Cc:     netdev@...r.kernel.org, hkallweit1@...il.com,
        linux@...linux.org.uk, davem@...emloft.net, kuba@...nel.org,
        f.fainelli@...il.com
Subject: Re: [PATCH 1/1] net: phy: marvell: enable downshift by default

On Wed, Apr 28, 2021 at 03:48:53PM +0300, Maxim Kochetkov wrote:
> Enable downshift for all supported PHYs by default like 88E1116R does.

Hi Maxim

Please expand the commit message. It does not explain enough, which is
why i asked the odd question. Maybe something like:

A number of PHYs support the PHY tunable to set and get
downshift. However, only 88E1116R enables downshift by default. Extend
this default enabled to all the PHYs that support the downshift
tunable.

     Andrew