netdev - Re: [PACTH iproute2-next] ip: dynamically size columns when printing stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210503122242.6ae77bde@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 3 May 2021 12:22:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...il.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PACTH iproute2-next] ip: dynamically size columns when
 printing stats

On Mon, 3 May 2021 11:16:41 -0600 David Ahern wrote:
> On 5/3/21 10:00 AM, Jakub Kicinski wrote:
> > On Mon, 3 May 2021 07:57:39 -0700 Stephen Hemminger wrote:  
> >> Maybe good time to refactor the code to make it table driven rather
> >> than individual statistic items.  
> > 
> > 🤔 should be doable.
> > 
> > Can I do it on top or before making the change to the columns?
> >   
> 
> I think it can be a follow on change. This one is clearly an improvement
> for large numbers.

Fun little discrepancy b/w JSON and plain on what's printed with -s 
vs -s -s: JSON output prints rx_over_errors where plain would print
rx_missed_errors. I will change plain to follow JSON, since presumably
we should worry more about breaking machine-readable format.