netdev - Re: [PACTH iproute2-next] ip: dynamically size columns when printing stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3737927a-7352-5a07-e19a-6b09470734a5@gmail.com>
Date:   Mon, 3 May 2021 20:15:27 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PACTH iproute2-next] ip: dynamically size columns when printing
 stats

On 5/3/21 1:22 PM, Jakub Kicinski wrote:
> On Mon, 3 May 2021 11:16:41 -0600 David Ahern wrote:
>> On 5/3/21 10:00 AM, Jakub Kicinski wrote:
>>> On Mon, 3 May 2021 07:57:39 -0700 Stephen Hemminger wrote:  
>>>> Maybe good time to refactor the code to make it table driven rather
>>>> than individual statistic items.  
>>>
>>> 🤔 should be doable.
>>>
>>> Can I do it on top or before making the change to the columns?
>>>   
>>
>> I think it can be a follow on change. This one is clearly an improvement
>> for large numbers.
> 
> Fun little discrepancy b/w JSON and plain on what's printed with -s 
> vs -s -s: JSON output prints rx_over_errors where plain would print
> rx_missed_errors. I will change plain to follow JSON, since presumably
> we should worry more about breaking machine-readable format.
> 

you mean from this commit?

commit b8663da04939dd5de223ca0de23e466ce0a372f7
Author: Jakub Kicinski <kuba@...nel.org>
Date:   Wed Sep 16 12:42:49 2020 -0700

    ip: promote missed packets to the -s row