lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 May 2021 20:36:31 -0400 From: Willem de Bruijn <willemdebruijn.kernel@...il.com> To: Richard Sanger <rsanger@...d.net.nz> Cc: Network Development <netdev@...r.kernel.org>, Daniel Borkmann <daniel@...earbox.net> Subject: Re: [PATCH] net: packetmmap: fix only tx timestamp on request On Mon, May 3, 2021 at 8:04 PM Richard Sanger <rsanger@...d.net.nz> wrote: > > The packetmmap tx ring should only return timestamps if requested, > as documented. This allows compatibility with non-timestamp aware > user-space code which checks tp_status == TP_STATUS_AVAILABLE; > not expecting additional timestamp flags to be set. This is an established interface. Passing the status goes back to 2013, since commit b9c32fb27170 ("packet: if hw/sw ts enabled in rx/tx ring, report which ts we got"). Passing a timestamp itself in tp_sec/tp_usec goes back to before git, probably to the introduction of the ring. I don't think we can change this now. That will likely break applications that have come to expect current behavior. Is it documented somewhere that the ring works differently? Or are you referring to the general SO_TIMESTAMPING behavior, which is a separate timestamp interface.
Powered by blists - more mailing lists