netdev - Re: [RFC net-next] net: stmmac: should not modify RX descriptor when STMMAC resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e75fee5a-0b98-58b0-4ec8-9a0646812392@gmail.com>
Date:   Sat, 8 May 2021 08:42:05 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Joakim Zhang <qiangqing.zhang@....com>,
        Jon Hunter <jonathanh@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        dl-linux-imx <linux-imx@....com>,
        "treding@...dia.com" <treding@...dia.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC net-next] net: stmmac: should not modify RX descriptor when
 STMMAC resume



On 5/8/2021 4:20 AM, Joakim Zhang wrote:
> 
> Hi Jakub,
> 
>> -----Original Message-----
>> From: Jon Hunter <jonathanh@...dia.com>
>> Sent: 2021年5月7日 22:22
>> To: Joakim Zhang <qiangqing.zhang@....com>; Jakub Kicinski
>> <kuba@...nel.org>
>> Cc: peppe.cavallaro@...com; alexandre.torgue@...s.st.com;
>> joabreu@...opsys.com; davem@...emloft.net;
>> mcoquelin.stm32@...il.com; andrew@...n.ch; f.fainelli@...il.com;
>> dl-linux-imx <linux-imx@....com>; treding@...dia.com;
>> netdev@...r.kernel.org
>> Subject: Re: [RFC net-next] net: stmmac: should not modify RX descriptor when
>> STMMAC resume
>>
>> Hi Joakim,
>>
>> On 06/05/2021 07:33, Joakim Zhang wrote:
>>>
>>>> -----Original Message-----
>>>> From: Jon Hunter <jonathanh@...dia.com>
>>>> Sent: 2021年4月23日 21:48
>>>> To: Jakub Kicinski <kuba@...nel.org>; Joakim Zhang
>>>> <qiangqing.zhang@....com>
>>>> Cc: peppe.cavallaro@...com; alexandre.torgue@...s.st.com;
>>>> joabreu@...opsys.com; davem@...emloft.net;
>> mcoquelin.stm32@...il.com;
>>>> andrew@...n.ch; f.fainelli@...il.com; dl-linux-imx
>>>> <linux-imx@....com>; treding@...dia.com; netdev@...r.kernel.org
>>>> Subject: Re: [RFC net-next] net: stmmac: should not modify RX
>>>> descriptor when STMMAC resume
>>>>
>>>>
>>>> On 22/04/2021 16:56, Jakub Kicinski wrote:
>>>>> On Thu, 22 Apr 2021 04:53:08 +0000 Joakim Zhang wrote:
>>>>>> Could you please help review this patch? It's really beyond my
>>>>>> comprehension, why this patch would affect Tegra186 Jetson TX2 board?
>>>>>
>>>>> Looks okay, please repost as non-RFC.
>>>>
>>>>
>>>> I still have an issue with a board not being able to resume from
>>>> suspend with this patch. Shouldn't we try to resolve that first?
>>>
>>> Hi Jon,
>>>
>>> Any updates about this? Could I repost as non-RFC?
>>
>>
>> Sorry no updates from my end. Again, I don't see how we can post this as it
>> introduces a regression for us. I am sorry that I am not able to help more here,
>> but we have done some extensive testing on the current mainline without your
>> change and I don't see any issues with regard to suspend/resume. Hence, this
>> does not appear to fix any pre-existing issues. It is possible that we are not
>> seeing them.
>>
>> At this point I think that we really need someone from Synopsys to help us
>> understand that exact problem that you are experiencing so that we can
>> ensure we have the necessary fix in place and if this is something that is
>> applicable to all devices or not.
> 
> This patch only removes modification of Rx descriptors when STMMAC resume back, IMHO, it should not affect system suspend/resume function.
> Do you have any idea about Joh's issue or any acceptable solution to fix the issue I met? Thanks a lot!

Joakim, don't you have a support contact at Synopsys who would be able
to help or someone at NXP who was responsible for the MAC integration?
We also have Synopsys engineers copied so presumably they could shed
some light.
-- 
Florian