netdev - Re: [PATCH v5 06/22] i40e: Register auxiliary devices to provide RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210519134349.GK1002214@nvidia.com>
Date:   Wed, 19 May 2021 10:43:49 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Shiraz Saleem <shiraz.saleem@...el.com>, dledford@...hat.com,
        kuba@...nel.org, davem@...emloft.net, linux-rdma@...r.kernel.org,
        netdev@...r.kernel.org, david.m.ertman@...el.com,
        anthony.l.nguyen@...el.com
Subject: Re: [PATCH v5 06/22] i40e: Register auxiliary devices to provide RDMA

On Wed, May 19, 2021 at 03:51:46PM +0300, Leon Romanovsky wrote:
> On Fri, May 14, 2021 at 09:11:58AM -0500, Shiraz Saleem wrote:
> > Convert i40e to use the auxiliary bus infrastructure to export
> > the RDMA functionality of the device to the RDMA driver.
> > Register i40e client auxiliary RDMA device on the auxiliary bus per
> > PCIe device function for the new auxiliary rdma driver (irdma) to
> > attach to.
> > 
> > The global i40e_register_client and i40e_unregister_client symbols
> > will be obsoleted once irdma replaces i40iw in the kernel
> > for the X722 device.
> > 
> > Signed-off-by: Shiraz Saleem <shiraz.saleem@...el.com>
> >  drivers/net/ethernet/intel/Kconfig            |   1 +
> >  drivers/net/ethernet/intel/i40e/i40e.h        |   2 +
> >  drivers/net/ethernet/intel/i40e/i40e_client.c | 152 ++++++++++++++++++++++----
> >  drivers/net/ethernet/intel/i40e/i40e_main.c   |   1 +
> >  4 files changed, 136 insertions(+), 20 deletions(-)
> 
> The amount of obfuscation in this driver is astonishing.
> 
> I would expect that after this series, the i40e_client_add_*() would
> be cleaned, for example simple grep of I40E_CLIENT_VERSION_MAJOR
> shows that i40e_register_client() still have no-go code.

While it would be nice to see i40e fully cleaned I think we agreed to
largely ignore it as-is so long as the new driver's aux implementation
was sane.

Jason