netdev - RE: [EXT] [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function name in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR18MB403932EAA58A847383EA6E54D32B9@PH0PR18MB4039.namprd18.prod.outlook.com>
Date:   Wed, 19 May 2021 09:30:48 +0000
From:   Sudarsana Reddy Kalluru <skalluru@...vell.com>
To:     Yang Shen <shenyang39@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>
Subject: RE: [EXT] [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function
 name in comments

> -----Original Message-----
> From: Yang Shen <shenyang39@...wei.com>
> Sent: Monday, May 17, 2021 10:15 AM
> To: davem@...emloft.net; kuba@...nel.org
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Yang Shen
> <shenyang39@...wei.com>; Ariel Elior <aelior@...vell.com>; Sudarsana
> Reddy Kalluru <skalluru@...vell.com>; GR-everest-linux-l2 <GR-everest-
> linux-l2@...vell.com>
> Subject: [EXT] [PATCH v2 05/24] net: broadcom: bnx2x: Fix wrong function
> name in comments
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13595: warning:
> expecting prototype for bnx2x_get_num_none_def_sbs(). Prototype was for
> bnx2x_get_num_non_def_sbs() instead
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4165: warning:
> expecting prototype for atomic_add_ifless(). Prototype was for
> __atomic_add_ifless() instead
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c:4193: warning:
> expecting prototype for atomic_dec_ifmoe(). Prototype was for
> __atomic_dec_ifmoe() instead
> 
> Cc: Ariel Elior <aelior@...vell.com>
> Cc: Sudarsana Kalluru <skalluru@...vell.com>
> Cc: GR-everest-linux-l2@...vell.com
> Signed-off-by: Yang Shen <shenyang39@...wei.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> index 281b1c2e04a7..2acbc73dcd18 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> @@ -13586,7 +13586,7 @@ static int bnx2x_set_qm_cid_count(struct bnx2x
> *bp)  }
> 
>  /**
> - * bnx2x_get_num_none_def_sbs - return the number of none default SBs
> + * bnx2x_get_num_non_def_sbs - return the number of none default SBs
>   * @pdev: pci device
>   * @cnic_cnt: count
>   *
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> index 6cd1523ad9e5..542c69822649 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
> @@ -4152,7 +4152,7 @@ void bnx2x_init_mcast_obj(struct bnx2x *bp,
>  /*************************** Credit handling
> **********************************/
> 
>  /**
> - * atomic_add_ifless - add if the result is less than a given value.
> + * __atomic_add_ifless - add if the result is less than a given value.
>   *
>   * @v:	pointer of type atomic_t
>   * @a:	the amount to add to v...
> @@ -4180,7 +4180,7 @@ static inline bool __atomic_add_ifless(atomic_t *v,
> int a, int u)  }
> 
>  /**
> - * atomic_dec_ifmoe - dec if the result is more or equal than a given value.
> + * __atomic_dec_ifmoe - dec if the result is more or equal than a given
> value.
>   *
>   * @v:	pointer of type atomic_t
>   * @a:	the amount to dec from v...
> --
> 2.17.1

Thanks for the changes.

Acked-by: Sudarsana Reddy Kalluru <skalluru@...vell.com>