netdev - Re: [PATCH net-next v2 2/2] usb: class: cdc-wdm: WWAN framework integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 May 2021 11:40:00 +0200
From:   Aleksander Morgado <aleksander@...ksander.es>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     Dan Williams <dcbw@...ps.redhat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Oliver Neukum <oliver@...kum.org>,
        "David S. Miller" <davem@...emloft.net>,
        Bjørn Mork <bjorn@...k.no>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 2/2] usb: class: cdc-wdm: WWAN framework integration

> > But another thought: why couldn't wwan_create_port() take a devname
> > template like alloc_netdev() does and cdc-wdm can just pass "cdc-
> > wdm%d"? eg, why do we need to change the name?
> > Tools that care about
> > finding WWAN devices should be looking at sysfs attributes/links and
> > TYPE=XXXX in uevent, not at the device name. Nothing should be looking
> > at device name really.
>
> Right, passing the legacy cdc-wdm dev-name as a parameter seems to be
> a fair solution, making the transition smoother.
>

Reusing the cdc-wdm name is indeed a good compromise; plus then
reading port type (QMI, MBIM...) via sysfs attributes as you suggested
in your last patch would make it work perfectly fine in userspace.

-- 
Aleksander
https://aleksander.es