netdev - Re: [PATCH 1/1] mISDN: Mark local variable 'incomplete' as __maybe_unused in dsp_pipeline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 May 2021 09:09:04 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     Karsten Keil <isdn@...ux-pingi.de>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] mISDN: Mark local variable 'incomplete' as
 __maybe_unused in dsp_pipeline_build()



On 2021/5/19 23:45, Leon Romanovsky wrote:
> On Wed, May 19, 2021 at 08:53:52PM +0800, Zhen Lei wrote:
>> GCC reports the following warning with W=1:
>>
>> drivers/isdn/mISDN/dsp_pipeline.c:221:6: warning:
>>  variable 'incomplete' set but not used [-Wunused-but-set-variable]
>>   221 |  int incomplete = 0, found = 0;
>>       |      ^~~~~~~~~~
>>
>> This variable is used only when macro PIPELINE_DEBUG is defined.
> 
> That define is commented 13 years ago and can be seen as a dead code
> that should be removed.

OK, I will remove it in V2. Actually, every time incomplete=1, a KERN_ERR message
is printed in advance. The only new information is the 'cfg'.

> 
> Thanks
> 
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
>> ---
>>  drivers/isdn/mISDN/dsp_pipeline.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/isdn/mISDN/dsp_pipeline.c b/drivers/isdn/mISDN/dsp_pipeline.c
>> index 40588692cec7..6a31f6879da8 100644
>> --- a/drivers/isdn/mISDN/dsp_pipeline.c
>> +++ b/drivers/isdn/mISDN/dsp_pipeline.c
>> @@ -218,7 +218,7 @@ void dsp_pipeline_destroy(struct dsp_pipeline *pipeline)
>>  
>>  int dsp_pipeline_build(struct dsp_pipeline *pipeline, const char *cfg)
>>  {
>> -	int incomplete = 0, found = 0;
>> +	int __maybe_unused incomplete = 0, found = 0;
>>  	char *dup, *tok, *name, *args;
>>  	struct dsp_element_entry *entry, *n;
>>  	struct dsp_pipeline_entry *pipeline_entry;
>> -- 
>> 2.25.1
>>
>>
> 
> .
>