netdev - Re: [PATCH 1/2] net: phy: fix yt8511 clang uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 May 2021 09:11:28 -0400
From:   Peter Geis <pgwipeout@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        clang-built-linux@...glegroups.com,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH 1/2] net: phy: fix yt8511 clang uninitialized variable warning

On Tue, May 25, 2021 at 9:02 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Tue, May 25, 2021 at 08:26:14AM -0400, Peter Geis wrote:
> > clang doesn't preinitialize variables. If phy_select_page failed and
> > returned an error, phy_restore_page would be called with `ret` being
> > uninitialized.
> > Even though phy_restore_page won't use `ret` in this scenario,
> > initialize `ret` to silence the warning.
> >
> > Fixes: b1b41c047f73 ("net: phy: add driver for Motorcomm yt8511 phy")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Peter Geis <pgwipeout@...il.com>
> > ---
> >  drivers/net/phy/motorcomm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
> > index 796b68f4b499..5795f446c528 100644
> > --- a/drivers/net/phy/motorcomm.c
> > +++ b/drivers/net/phy/motorcomm.c
> > @@ -51,7 +51,7 @@ static int yt8511_write_page(struct phy_device *phydev, int page)
> >  static int yt8511_config_init(struct phy_device *phydev)
> >  {
> >       unsigned int ge, fe;
> > -     int ret, oldpage;
> > +     int oldpage, ret = 0;
>
> Please keep to reverse Christmas tree.

Ah, I missed that.
Do you want a v2 or will it be fixed on application?

>
> With that fixed:
>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
>
>     Andrew

Thanks!
Peter